sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs

https://sendgrid.com

MIT License

125 stars 101 forks source link

converted README and version as file #93

Closed StrikerRUS closed 5 years ago

StrikerRUS commented 5 years ago

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[x] I have added tests that prove my fix is effective or that my feature works
[n/a] I have added necessary documentation about the functionality in the appropriate .md file
[n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

add standard __version__ attribute to the package. This attribute is read from the VERSION.txt file, so in the future version should be incremented only in the file (related to #92).
convert README.md to README.rst (appearance can be checked in this branch https://github.com/StrikerRUS/python-http-client/blob/pypi/README.rst), so setup.cfg and register.py are not needed anymore.
add Python versions badge.
add PyPI version badge.

SendGridDX commented 5 years ago

All committers have signed the CLA.

codecov[bot] commented 5 years ago

Codecov Report

Merging #93 into master will increase coverage by 0.11%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   91.34%   91.46%   +0.11%     
==========================================
  Files           6        6              
  Lines         289      293       +4     
==========================================
+ Hits          264      268       +4     
  Misses         25       25

Impacted Files	Coverage Δ
tests/test_repofiles.py	`100% <ø> (ø)`	:arrow_up:
python_http_client/__init__.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9196b9f...4f8466a. Read the comment docs.

StrikerRUS commented 5 years ago

~All tests on Travis are green, but the status on GitHub hasn't been updated. If it's an issue, then closing and reopening the PR can help.~ Not actual anymore.

thinkingserious commented 5 years ago

Hello @StrikerRUS,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious commented 5 years ago

This is awesome @StrikerRUS! Would you mind doing the same for our other Python repos?

https://github.com/sendgrid/sendgrid-python https://github.com/sendgrid/smtpapi-python https://github.com/sendgrid/open-source-library-data-collector https://github.com/sendgrid/dx-automator

Thanks!

With Best Regards,

Elmer

StrikerRUS commented 5 years ago

@thinkingserious Thanks a lot for the kind words!

Sure, I'll create PRs for other repos. BTW, the similar PR for sendgrid-python has been already created: https://github.com/sendgrid/sendgrid-python/pull/634.

StrikerRUS commented 5 years ago

@thinkingserious Here're updates about PRs. Please take a look.

sendgrid/sendgrid-python: ~https://github.com/sendgrid/sendgrid-python/pull/634~ https://github.com/sendgrid/sendgrid-python/pull/663.
sendgrid/smtpapi-python: https://github.com/sendgrid/smtpapi-python/pull/75.
sendgrid/open-source-library-data-collector: https://github.com/sendgrid/open-source-library-data-collector/pull/138.
sendgrid/dx-automator: Not needed.