sendgrid / ruby-http-client

SendGrid's Ruby HTTP Client for calling APIs

https://sendgrid.com

MIT License

23 stars 54 forks source link

fix: Avoid mutating @url_path to avoid unexpected side effects #108

Closed tachyons closed 5 years ago

tachyons commented 5 years ago

Fixes #93

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the development branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

method _ mutates @url_path and it can have unintended side effects like #93. This PR remove that mutation

SendGridDX commented 5 years ago

All committers have signed the CLA.

thinkingserious commented 5 years ago

Hello @tachyons,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX