sendgrid / ruby-http-client

SendGrid's Ruby HTTP Client for calling APIs
https://sendgrid.com
MIT License
23 stars 54 forks source link

Add a helper returns the response body as a hash #12

Closed diegoc-am closed 7 years ago

diegoc-am commented 7 years ago

I think the body is already a json string, therefore I only created a method to allow it to be hash

SendGridDX commented 7 years ago

CLA assistant check
All committers have signed the CLA.

diegoc-am commented 7 years ago

Built the gem and ran the tests against sendgrid-ruby, nothing failed

sendgrid-ruby git:master ❯ bundle exec rake test                                                                                                             ⏎
/home/diego/.rbenv/versions/2.4.1/bin/ruby -I"lib:test" -I"/home/diego/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rake-0.9.6/lib" "/home/diego/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rake-0.9.6/lib/rake/rake_test_loader.rb" "test/sendgrid/test_sendgrid-ruby.rb" "test/sendgrid/helpers/mail/test_category.rb" "test/sendgrid/helpers/mail/test_mail.rb" "test/sendgrid/helpers/mail/test_personalizations.rb" 
Activating Prism (~20 seconds)
Prism started
Run options: --seed 8574

# Running:

................................................................................................................................................................................................................................................................

Finished in 14.516840s, 17.6347 runs/s, 18.3235 assertions/s.

256 runs, 266 assertions, 0 failures, 0 errors, 0 skips
Prism shut down
diegoc-am commented 7 years ago

I think I've already signed the CLA before

thinkingserious commented 7 years ago

Hello @belfazt,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX