sendgrid / ruby-http-client

SendGrid's Ruby HTTP Client for calling APIs

https://sendgrid.com

MIT License

23 stars 54 forks source link

fix: Mistake on setup http_options for Net::HTTP object when build http #124

Closed hoangtuanictvn closed 3 years ago

hoangtuanictvn commented 3 years ago

Fixes

Add http_options when setup Net:HTTP object to fix the mistake from PR #67

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

codecov[bot] commented 3 years ago

Codecov Report

Merging #124 (4cd4a4d) into main (3059289) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   95.60%   95.75%   +0.14%     
==========================================
  Files           2        2              
  Lines         341      353      +12     
==========================================
+ Hits          326      338      +12     
  Misses         15       15

Impacted Files	Coverage Δ
lib/ruby_http_client.rb	`91.66% <100.00%> (+0.43%)`	:arrow_up:
test/test_ruby_http_client.rb	`97.85% <100.00%> (+0.05%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3059289...4cd4a4d. Read the comment docs.

hoangtuanictvn commented 3 years ago

Happy new year! Because of the old date in the license, the Travis CI had failed. If it is possible, I will update the year of the license from 2020 to 2021.

hoangtuanictvn commented 3 years ago

@eshanholtz Thank you, I am sorry, but would it be possible to change the date in the license?

eshanholtz commented 3 years ago

@hoangtuanictvn

Yup! We're looking to get the license updated across the board today.

hoangtuanictvn commented 3 years ago

@eshanholtz I have updated the code based on the update of the license. Because the old implemented in Net:HTTP on ruby versions 2.4, 2.5 and jruby. CI didn't pass with a small error in the test. But don't worry, I fixed it there 4cd4a4d . And I hope that you can review it again.

Thanks a lot!

hoangtuanictvn commented 3 years ago

Good morning,

I have pushed a PR https://github.com/sendgrid/sendgrid-ruby/pull/455 to add some feature about http_options in the sendgrid-ruby gem. However, the test had failed (https://github.com/sendgrid/sendgrid-ruby/pull/455#issuecomment-757498782) because this PR hasn't released. I am waiting it. So, could you tell me when is it release?