search

sendgrid / ruby-http-client

SendGrid's Ruby HTTP Client for calling APIs
https://sendgrid.com
MIT License
23 stars 54 forks source link

Timeout configuration #13

Closed thinkingserious closed 6 years ago

thinkingserious commented 7 years ago

Please see this issue.

guille commented 7 years ago

Hey @thinkingserious I've submitted a PR. Let me know what you think!

jrectenwald commented 7 years ago

Hey @thinkingserious, I took a stab at this as well in this PR.

thinkingserious commented 7 years ago

Hi @jrectenwald,

Could you please summarize what is different from @guille's implementation. I'd love to figure out a way to get both of your work recognized.

jrectenwald commented 7 years ago

The only difference is that the attribute names aren't hard coded in, so users would be able to set values for attributes other than read_timeout or open_timeout.

thinkingserious commented 7 years ago

Thanks for the clarification @jrectenwald,

I do like the idea of passing in http_options for the flexibility.

What are your thoughts @guille? You have dibs since you submitted first :)

guille commented 7 years ago

Hey, if you like the idea I'm okay with merging that instead of mine, especially now that his PR has tests.