sendgrid / ruby-http-client

SendGrid's Ruby HTTP Client for calling APIs
https://sendgrid.com
MIT License
23 stars 54 forks source link

feat: Add option to set http attributes when creating an instance of Client #20

Closed jrectenwald closed 6 years ago

jrectenwald commented 7 years ago

This PR is addressing issue #13

The Problem The issue requests the ability to override the Net::HTTP defaults for open and read timeouts.

What I did I added a parameter called http_options to the Sendgrid::Client class. This parameter should be a hash with key/value pairs corresponding with attributes for NET:HTTP as described here. I added this in the test file and added this to the example file as well.

thinkingserious commented 6 years ago

Hello @jrectenwald,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

SendGridDX commented 6 years ago

CLA assistant check
All committers have signed the CLA.