sendgrid / ruby-http-client

SendGrid's Ruby HTTP Client for calling APIs

https://sendgrid.com

MIT License

23 stars 54 forks source link

fix: Split up the build_request function to logical component functions to reduce method complexity #67

Closed sony-mathew closed 4 years ago

sony-mathew commented 6 years ago

This commit Fixes #54

Fixes

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation about the functionality in the appropriate .md file
[x] I have added in line documentation to the code I modified

Short description of what this PR does:

Splitting up the build_request function to logical component functions to reduce method complexity
Changing %w() to %w[] as per rubocop warnings

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

SendGridDX commented 6 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: sony-mathew
:x: childish-sambino
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8ed745b). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage          ?   95.45%           
=========================================
  Files             ?        2           
  Lines             ?      286           
  Branches          ?        0           
=========================================
  Hits              ?      273           
  Misses            ?       13           
  Partials          ?        0

Impacted Files	Coverage Δ
test/test_ruby_http_client.rb	`97.43% <100%> (ø)`
lib/ruby_http_client.rb	`91.2% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ed745b...471391a. Read the comment docs.

thinkingserious commented 4 years ago

Hello @sony-mathew,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX