sendgrid / ruby-http-client

SendGrid's Ruby HTTP Client for calling APIs

https://sendgrid.com

MIT License

23 stars 54 forks source link

update LICENSE - fix year, changing to .md file #74

Closed myzeprog closed 6 years ago

myzeprog commented 6 years ago

Fixes

Checklist

[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[ ] I have read the [Contribution Guide] and my PR follows them.
[ ] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

update year in license, rename to .md

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

SendGridDX commented 6 years ago

All committers have signed the CLA.

kplimack commented 6 years ago

@myzeprog looking past the other errors that Travis surfaced, the tests for this repo are still looking for a license.txt file, you'll need to update the tests accordingly.

  4) Error:
TestClient#test_license_date_is_updated:
Errno::ENOENT: No such file or directory @ rb_sysopen - LICENSE.txt
    /home/travis/build/sendgrid/ruby-http-client/test/test_ruby_http_client.rb:253:in `read'
    /home/travis/build/sendgrid/ruby-http-client/test/test_ruby_http_client.rb:253:in `test_license_date_is_updated'

you can test locally by running bundle exec rake test

myzeprog commented 6 years ago

@myzeprog looking past the other errors that Travis surfaced, the tests for this repo are still looking for a license.txt file, you'll need to update the tests accordingly.
  4) Error:
TestClient#test_license_date_is_updated:
Errno::ENOENT: No such file or directory @ rb_sysopen - LICENSE.txt
    /home/travis/build/sendgrid/ruby-http-client/test/test_ruby_http_client.rb:253:in `read'
    /home/travis/build/sendgrid/ruby-http-client/test/test_ruby_http_client.rb:253:in `test_license_date_is_updated'
you can test locally by running bundle exec rake test

I updated this test, thanks

thinkingserious commented 6 years ago

Hello @myzeprog,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious commented 6 years ago

Sorry @myzeprog,

I fixed this before seeing your PR. As you can see, I still gave you Hacktoberfest credit :)