sendgrid / ruby-http-client

SendGrid's Ruby HTTP Client for calling APIs
https://sendgrid.com
MIT License
23 stars 54 forks source link

test: Fix rubocop.yml formatting warnings #98

Closed RolandBurrows closed 4 years ago

RolandBurrows commented 5 years ago

Short description of what this PR does:

Previous rubocop output:

ruby-http-client$ rubocop
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout
Inspecting 7 files
.......
7 files inspected, no offenses detected

After this PR's changes:

ruby-http-client$ rubocop
Inspecting 7 files
.......
7 files inspected, no offenses detected

This change required re-alphabetizing the rubocop.yml entries list, and there were pre-existing mis-ordered entries that are now properly alphabetized as well.

Checklist

SendGridDX commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #98 into master will increase coverage by 1.31%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   94.14%   95.45%   +1.31%     
==========================================
  Files           2        2              
  Lines         239      286      +47     
==========================================
+ Hits          225      273      +48     
+ Misses         14       13       -1
Impacted Files Coverage Δ
test/test_ruby_http_client.rb 97.43% <100%> (+0.66%) :arrow_up:
lib/ruby_http_client.rb 91.2% <100%> (+1.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cd5461...80b9827. Read the comment docs.

thinkingserious commented 4 years ago

Hello @RolandBurrows,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX