sendgrid / sendgrid-go

The Official Twilio SendGrid Golang API Library

https://sendgrid.com

MIT License

984 stars 260 forks source link

feat: go 1.20 compatibility #467

Open nmemoto opened 1 year ago

nmemoto commented 1 year ago

Fixes

This PR updates the application to be compatible with go 1.20

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added the necessary documentation about the functionality in the appropriate .md file
[x] I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

nmemoto commented 1 year ago

All tests are green https://github.com/nmemoto/sendgrid-go/actions/runs/5285866793/jobs/9564752335

Abonive commented 1 year ago

Any update on this? @childish-sambino

natiiaparicio commented 1 year ago

When do you plan to review/approve this PR ? @childish-sambino

porterctrlz commented 1 year ago

What's the blocker to this being merged?

porterctrlz commented 12 months ago

Also runs cleanly on 1.21: https://github.com/controlzee/sendgrid-go/actions/runs/6713922883, but I'll take what I can get in terms of merged PRs

lopezator commented 10 months ago

No maintenance here?

porterctrlz commented 3 months ago

@tiwarishubham635 would you be placed to merge stuff like this?

matthew-raul commented 3 weeks ago

This is sad.