sendgrid / sendgrid-java

The Official Twilio SendGrid Led, Community Driven Java API Library

https://sendgrid.com

MIT License

483 stars 408 forks source link

chore: move Bouncy Castle dependency to test scope #750

Closed mrdziuban closed 4 days ago

mrdziuban commented 3 months ago

Fixes

Fixes #749 by moving the Bouncy Castle dependency to the test scope

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

mrdziuban commented 2 months ago

@shrutiburman would you mind taking a look at this when you have a chance? Thank you!

k163377 commented 1 month ago

Are there any plans for this to be a merge release?

tiwarishubham635 commented 3 weeks ago

Hi @mrdziuban! This looks good to me, however, it would be better if we can bump the version 1.76 to 1.78 because that version is free from the vulnerability. Can you make this change? I'll approve and merge it

mrdziuban commented 3 weeks ago

Sure thing @tiwarishubham635, just updated it to the latest 1.78.1 version.

tiwarishubham635 commented 3 weeks ago

Thanks a lot @mrdziuban! The tests are failing currently coz docker-compose has moved to v2 in github. So need to update it. I'll do it and merge this PR. Thanks again!

tiwarishubham635 commented 4 days ago

Fixed by #767. @mrdziuban please review it once and I'll merge it

mrdziuban commented 4 days ago

Looks good to me, thanks @tiwarishubham635! I'll close this since the changes were included in #767