sendgrid / sendgrid-nodejs

The Official Twilio SendGrid Led, Community Driven Node.js API Library
https://sendgrid.com
MIT License
2.98k stars 781 forks source link

docs: Fix broken url on npmjs #1376

Closed umarfchy closed 1 year ago

umarfchy commented 1 year ago

Fixes

Some of the links in the package's npmjs landing page are broken because of being referenced by the relative path. This pr updates the links by referencing the document using the URLs which resolves the issue.

Checklist

If you have questions, please file a support ticket.

umarfchy commented 1 year ago

Hi @childish-sambino, would you mind taking a look into this? The PR requires approval from the maintainers to run the workflow. Thanks 🙂

umarfchy commented 1 year ago

@childish-sambino Thanks for approving the PR. It seems the failing tests are related to npm and not necessarily related to the PR itself which is only related to docs itself.

umarfchy commented 1 year ago

@childish-sambino hope you're well. Would you kindly let me know the step I should take to pass all the tests from CI? Although the change was made only to the docs, it seems I need to do something else to make sure the rest of the tests pass. Thanks.