sendgrid / sendgrid-nodejs

The Official Twilio SendGrid Led, Community Driven Node.js API Library

https://sendgrid.com

MIT License

2.98k stars 781 forks source link

feat!: node version upgrade, axios upgrade #1391

Closed shrutiburman closed 9 months ago

shrutiburman commented 9 months ago

Fixes

This PR: Drops support for node v 6, 8, 10

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[ ] I have read the Contribution Guidelines and my PR follows them
[ ] I have titled the PR appropriately
[ ] I have updated my branch with the main branch
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

tovbinm commented 9 months ago

@tiwarishubham635 @manisha1997 can you please trigger a release for this version?

jakebanks commented 9 months ago

Is anyone else getting axios3 is not a function or similar when calling send() since updating? (i'm on 8.1.0)

I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment).

So my imports changed from

const axios = require('axios');

const axios = require('axios').default;

Don't know enough about JS modules to understand if this change is also required here.

Capta1nRaj commented 8 months ago

Never till launch.

Capta1nRaj commented 8 months ago

Is anyone else getting axios3 is not a function or similar when calling send() since updating? (i'm on 8.1.0)

I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment).

So my imports changed from
const axios = require('axios');
to
const axios = require('axios').default;
Don't know enough about JS modules to understand if this change is also required here.

Can you share your axios verion?

"@sendgrid/mail": "^8.0.0",
"axios": "^1.6.2",

these are mine

jakebanks commented 8 months ago

Is anyone else getting axios3 is not a function or similar when calling send() since updating? (i'm on 8.1.0) I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment). So my imports changed from
const axios = require('axios');
to
const axios = require('axios').default;
Don't know enough about JS modules to understand if this change is also required here.
Can you share your axios verion?
"@sendgrid/mail": "^8.0.0",
"axios": "^1.6.2",

these are mine

Sure, I'm using

@sendgrid/mail at 8.1.0 axios 1.6.5