sendgrid / sendgrid-php

The Official Twilio SendGrid PHP API Library
https://sendgrid.com
MIT License
1.49k stars 624 forks source link

feat: Added Data residency for eu and global region #1104

Closed tiwarishubham635 closed 9 months ago

tiwarishubham635 commented 10 months ago

Fixes

Adding data residency with global as the default region and adding support for eu region as well.

Checklist

If you have questions, please file a support ticket.

tiwarishubham635 commented 10 months ago

The checks are failing as of now since the php-http-client PR is not merged due to which setHost is not working.

tiwarishubham635 commented 9 months ago

The php-http-client PR is merged, however it is not released. That's why when make test-docker is run, the docker container is not able to pick the merged changes. I am attaching screenshots of the local environment where I manually made changes and the tests are passing.

Output of make test

Screenshot 2023-11-21 at 11 45 43 AM

Output of running the test fie - DataResidencyTest.php

Screenshot 2023-11-21 at 11 46 24 AM

tbischel commented 9 months ago

There do seem to be a lot of failing checks...

shrutiburman commented 9 months ago

We probably in all the examples should note that to use the EU region, their subuser must be pinned. One thing I'm wondering is if we should link to the docs for how subuser pinning will work. These do not exist yet publicly, so we may want a followup round to add a link to the documentation in example comments next quarter.

Makes sense, I can create a ticket to add the documentation link in all SDKs, when its available publicly.