chore: pin starkbank-ecdsa version

eshanholtz commented 2 years ago

Fixes #1014

shwetha-manvinkurke commented 2 years ago

Doesn't work for versions <3.6 looks like - https://app.travis-ci.com/github/sendgrid/sendgrid-python

amcquistan commented 2 years ago

need to fix this in setup.py otherwise I don't think this will pip install correctly from PyPI

def getRequires():
    deps = [
        'python_http_client>=3.2.1',
        'starkbank-ecdsa>=1.0.0,<2.0.0'
    ]
    return deps

amcquistan commented 2 years ago

the following will use the dependencies in setup.py which is why the CircleCI builds are failing. The dependencies in setup.py need to be pinned to starkbank-ecdsa>=1.0.0,<2.0.0

Step 8/8 : RUN make install
 ---> Running in cb501b823e17
find . -name \*.pyc -delete
rm -rf venv
Python 2.7.18
virtualenv --python=python venv
created virtual environment CPython2.7.18.final.0-64 in 265ms
  creator CPython2Posix(dest=/app/venv, clear=False, global=False)
  seeder FromAppData(download=False, pip=latest, setuptools=latest, wheel=latest, via=copy, app_data_dir=/root/.local/share/virtualenv/seed-app-data/v1.0.1)
  activators PythonActivator,CShellActivator,FishActivator,PowerShellActivator,BashActivator
. venv/bin/activate; python setup.py install

You can see in the output of the build it is still trying to use version 2.0.0

  File "/app/venv/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py", line 1731, in zipinfo
    return self._zip_manifests.load(self.loader.archive)
  File "/app/venv/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py", line 1688, in load
    mtime = os.stat(path).st_mtime
OSError: [Errno 2] No such file or directory: '/app/venv/lib/python2.7/site-packages/starkbank_ecdsa-2.0.0-py2.7.egg'
make: *** [Makefile:9: install] Error 1

eshanholtz commented 2 years ago

Ah, great catch! thanks @amcquistan!

sendgrid / sendgrid-python

chore: pin starkbank-ecdsa version #1015