Mail dynamic_template_data returns None

sendgrid / sendgrid-python

The Official Twilio SendGrid Python API Library

https://sendgrid.com

MIT License

1.55k stars 714 forks source link

Mail dynamic_template_data returns None #931

Open C0DK opened 4 years ago

C0DK commented 4 years ago

The following line seems pretty NotImplementedError to me, but i'm not sure if it's on purpose. https://github.com/sendgrid/sendgrid-python/blob/d7ee47b56b171e82c20e4dfd9ae5a3f79eb71a85/sendgrid/helpers/mail/mail.py#L627

It is a bit bad that i had to read the soruce to debug why it wasn't accessible. Would this be solveable on your end? so it actually returns the dictionary you input?

C0DK commented 4 years ago

also applicable here: https://github.com/sendgrid/sendgrid-python/blob/d7ee47b56b171e82c20e4dfd9ae5a3f79eb71a85/sendgrid/helpers/mail/mail.py#L207

eshanholtz commented 4 years ago

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.