search

sendgrid / sendgrid-python

The Official Twilio SendGrid Python API Library
https://sendgrid.com
MIT License
1.53k stars 711 forks source link

Support for text/x-amp-html mime type #940

Closed SergeNasr closed 3 years ago

SergeNasr commented 3 years ago

Issue Summary - Feature Request

I am trying to use the SendGrid python client to send AMP dynamic emails. AMP emails require the text/x-amp-html content type as per SendGrid's doc However the python library does not support the text/x-amp-html mime type yet.

thinkingserious commented 3 years ago

Hello @SergeNasr,

Thank you for this request! This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

Note: the mime-type ordering will likely need to be considered.

With best regards,

Elmer

childish-sambino commented 3 years ago

May be fixed by https://github.com/sendgrid/sendgrid-python/pull/851

SergeNasr commented 3 years ago

@childish-sambino I think we would also need to add a if amp_content in https://github.com/sendgrid/sendgrid-python/blob/v6.1.0/sendgrid/helpers/mail/mail.py#L74 and also the mime-type ordering linked by @thinkingserious

modernwarfareuplink commented 3 years ago

@SergeNasr have added support for this here. Feel free to clone that branch and use if you are blocked on something and add your feedback. Thanks