sendgrid / sendgrid-python

The Official Twilio SendGrid Python API Library

https://sendgrid.com

MIT License

1.55k stars 714 forks source link

feat: Support for AMP HTML Email #945

Closed modernwarfareuplink closed 3 years ago

modernwarfareuplink commented 4 years ago

I acknowledge that my contributions will be made under the same open-source license that the open-source project is provided under

Adds support for sending AMP HTML email

Added third mime type -> text/x-amp-html
Send AMP HTML email just like normal html/plain email

Resolves

Fixes #940
Fixes #850

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added the necessary documentation about the functionality in the appropriate .md file
[x] I have added inline documentation to the code I modified

modernwarfareuplink commented 4 years ago

@thinkingserious need your superpowers here !!! . Please check and let me know about the PR. Thanks

modernwarfareuplink commented 3 years ago

@thinkingserious gentle reminder. Please let me know if you need any help regarding review. Thanks

modernwarfareuplink commented 3 years ago

Thanks for the review @thinkingserious. Will update in 2 days, caught up with something. Will let you know, once the changes are done.

thinkingserious commented 3 years ago

That sounds good @modernwarfareuplink, thank you!

modernwarfareuplink commented 3 years ago

Thanks for the review. I am really sorry that it took this long and no updates from my side. Will finish adding the tests by morning (in around 12 hours) and let you know. Thank you and happy new year @thinkingserious

modernwarfareuplink commented 3 years ago

@thinkingserious have resolved your comments, made few changes around the ordering and added appropriate tests. Also found that the build was failing due to copyrights year and fixed it too. Please review and let me know if you need any additional details. Thank you

modernwarfareuplink commented 3 years ago

@thinkingserious gentle reminder for review. Please let me know if you have any issues. Thank you

modernwarfareuplink commented 3 years ago

Have updated the minor comment @JenniferMah . Please do have a look once. Thank you

modernwarfareuplink commented 3 years ago

@thinkingserious need your superpowers for review and merging the changes 🙏

modernwarfareuplink commented 3 years ago

Thank you @JenniferMah