feat: Add http_options as a param in the SendGrid::API's constructor

sendgrid / sendgrid-ruby

The Official Twilio SendGrid Led, Community Driven Ruby API Library

https://sendgrid.com

MIT License

620 stars 324 forks source link

feat: Add http_options as a param in the SendGrid::API's constructor #455

Closed hoangtuanictvn closed 3 years ago

hoangtuanictvn commented 3 years ago

Closes #449

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added inline documentation to the code I modified

hoangtuanictvn commented 3 years ago

Because the mistake in implement of https://github.com/sendgrid/ruby-http-client/pull/67 in the ruby-http-client, the http_options didn't set right. So, the test in CI had failed to assert some value in http_options.

I also fixed it here https://github.com/sendgrid/ruby-http-client/pull/124

I will update the ruby-http-client dependency of this sendgrid-ruby gem when the new version were released. And I hope the test of this PR is going to pass.

hoangtuanictvn commented 3 years ago

Hello owners of this gem.

~Because of some problem in the SSL certificate only in jruby:9.2, the test had failed. However, I didn't know more about the configs in your CI. So, I'm happy to waiting for any owner to figure out for me about this problem.~

Sorry for my mistake. I had used an unavailable mocked endpoint for the test. So the error occurs. I had fixed it. Everything seems good.