No response in Internet Explorer browsers (Windows 7)

[Sebastix]

Hi,

It seems like the widget is not working in any version of Internet Explorer. I tested versions 8, 9 en 10 on a Windows 7 OS (Virtual Machine). I used the basic widget demo page as test page: http://sendgrid.github.io/sendgrid-subscription-widget/examples/basic.html

Attached screenshot of the console giving the errors.

[nquinlan]

Thanks for filing the issue. I think it was an implementation error by way of the example (rather than an issue with the widget itself). 1d0e7c65ef16ec634c2cf1e4178fd252d59ae5d9 seems to have fixed the issue. Let me know if you continue to see the issue.

Verified with Sauce Labs:

• Windows 7 / IE 8: https://saucelabs.com/tests/6caa96c67b58459ca792ab90f09980f3
• Windows 7 / IE 9: https://saucelabs.com/tests/6df17b37be594d009238d9d930bdb91c
• Windows 8 / IE 10: https://saucelabs.com/tests/558aabefd48a4da1a519b83fb8418cc2

cc: @nicusg

[Sebastix]

Thanks for the quick reply! I just tested it and checked if the location of the widget was changed (and it was). But I still get the same errors in the console.

[nquinlan]

Hmm, alright. I'll keep looking into it. Maybe @brandonmwest could lend some insight?

[brandonmwest]

Hi @Sebastix, I am also unable to replicate the issue. Can you share the url where you are having trouble, either here or in an email to community at sendgrid . com ?

[brandonmwest]

Aha, I believe I've found the problem. It seems to be due to a recent ops change on our side; requests to the subscription widget endpoint are now being redirected to HTTPS and IE doesn't like that.

@nquinlan What do you think the impact of always posting over HTTPS would be? https://github.com/sendgrid/sendgrid-subscription-widget/blob/master/src/widget.js#L397-L402

I can work with ops to change that redirect but requiring HTTPS is ideal.

[nquinlan]

@brandonmwest More than happy to always require HTTPS. Beyond slightly slower connections, I see little negative impact.

[brandonmwest]

Sounds good. I'll submit a PR and then let you work on getting it out to the CDN :)

On Sat, Apr 19, 2014 at 10:36 AM, Nick Quinlan notifications@github.comwrote:

@brandonmwest https://github.com/brandonmwest More than happy to always require HTTPS. Beyond slightly slower connections, I see little negative impact.

— Reply to this email directly or view it on GitHubhttps://github.com/sendgrid/sendgrid-subscription-widget/issues/6#issuecomment-40873941 .

[brandonmwest]

Hopefully #7 will sort this out.

[brandonmwest]

@nquinlan has this been deployed yet? can we close?

[nquinlan]

Yeah. Sorry about that. It was deployed the day it was merged.

[brandonmwest]

[brandonmwest]

@nquinlan are you sure this got deployed? I don't see the change on http://s3.amazonaws.com/subscription-cdn/0.2/widget.min.js

I see sendRequest=function(a,b,c){a="https:"===location.protocol?"https://"+a:"http://"+a;

[nquinlan]

fixed (whoops)