search

sendinblue / APIv3-php-library

SendinBlue's API v3 Php Library
MIT License
211 stars 94 forks source link

php 8.1 compatibility #239

Open Pascal76 opened 2 years ago

Pascal76 commented 2 years ago

Hello,

PHP 7.4 is being EOL very soon. A lot of people will migrate to PHP 8.1. Could you make this librairy compatible please ?

Ex: PHP Deprecated: Return type of SendinBlue\Client\Model\GetEmailCampaigns::offsetExists($offset) should either be compatible with ArrayAccess::offs etExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /apache_sites/jbm/lib_8.1/vendor/sendinblue/api-v3-sdk/li b/Model/GetEmailCampaigns.php

Clemweb commented 2 years ago

Up

deguif commented 2 years ago

This has been contributed upstream on the swagger-codegen generator project : https://github.com/swagger-api/swagger-codegen/pull/11846

This was released as of version 1.0.36 : https://github.com/swagger-api/swagger-codegen-generators/releases/tag/v1.0.36

To fix these deprecations the classes should be generated with the new tool version.

david-services commented 1 year ago

Up

barto74 commented 1 year ago

Please update the API as very soon as possible as PHP7 is EOL.

stkrelax commented 1 year ago

Could you please update the library ???

preetishishodia7 commented 1 year ago

HI, currently we are supporting PHP 7.4. We are working on it to support php 8+.

deguif commented 1 year ago

Should be fixed with the latest release, published an hour ago