sendinblue / APIv3-typescript-library

SendinBlue's API v3 client
40 stars 19 forks source link

Fix deprecated typings #38

Open dkress59 opened 3 years ago

dkress59 commented 3 years ago

Hello, everyone,

I believe this will also fix issues #16 and #33: I am currently converting an express-app (which among other things server-side-renders a react-spa) to a NestJS monorepo and am running into issues as soon as I import something from your library. I identified the source of the problem to be in the deprecated @types/request package (in my case an import from uuid v3.x, current uuid version is 8.x).

This PR swaps out the deprecated typings with the @types/node package by DefinitelyTyped ("The repository for high quality TypeScript type definitions") that covers all node built-ins.

Someone from #23 should probably also take a look at this.