sendinblue / APIv3-typescript-library

SendinBlue's API v3 client
40 stars 19 forks source link

Update deprecated dependencies #44

Open davide-scalzo opened 2 years ago

davide-scalzo commented 2 years ago

When installing the library the following pops up:

warning @sendinblue/client > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning @sendinblue/client > request > uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
warning @sendinblue/client > request > har-validator@5.1.5: this library is no longer supported

Would be good to use updated dependencies

supercairos commented 2 years ago

Yes please!

🙏

Kondamon commented 2 years ago

Still deprecated dependencies, please update!

npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
Alcas1 commented 1 year ago

The team seems to be 😴

jacobg commented 1 year ago

@sendinblue/client is relying on the deprecated request library that has not been updated in over 3 years. npm shows a big red warning over it.

sendinblue should switch to axios or one of the other alternative libraries recommended here: https://github.com/request/request/issues/3143

Whatever you choose, please make sure the library is easy to mock, e.g. axios-mock-adapter.

Screenshot 2023-02-26 at 2 15 50 PM
jacobg commented 1 year ago

@aayush-sib

Charlygraphy23 commented 1 year ago

hey team can you assign this task to me. request package can be converted to node-fetch or axios.

alfaproject commented 1 year ago

Honestly guys, if this package is not maintained just let us know so we can build our own bindings