search

sendsmaily / smaily-magento-extension

Smaily extension for Magento 2.3 and newer
GNU General Public License v3.0
0 stars 3 forks source link

Third option for reCAPTCHA usage #25

Closed sinukaarel closed 5 years ago

sinukaarel commented 5 years ago

There can be issues when store owners use another module to enable reCAPTCHA for their site.

For example Mageplaza reCAPTCHA module checks capcha before every frontend controller action in events listener config

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
    <event name="controller_action_predispatch">
        <observer name="mageplaza_captcha_frontend" instance="Mageplaza\GoogleRecaptcha\Observer\Captcha"/>
    </event>
</config>

This action causes to validate CAPTCHA multiple times. Once for their observer and once for our newsletter controller observer. That means our CAPTCHA validation fails with duplicate status.

We could add a third option to CAPTCHA list for their plugin to be used as bot controller and check if their plugin is activated during settings page validation.

sinukaarel commented 5 years ago

Added option disable CAPTCHA #27