Upgrade restler dependency to 3.4.0

sendwithus / sendwithus_nodejs

Sendwithus NodeJS Client

https://www.sendwithus.com

Apache License 2.0

22 stars 17 forks source link

Upgrade restler dependency to 3.4.0 #25

Closed lbstr closed 7 years ago

lbstr commented 7 years ago

Performing restler version update as described in this issue
- dependency goes from ~3.2.2 to ~3.4.0
The underlying nsp vulnerability goes away once restler is updated to 3.4.0
The tests still pass with the new version of restler
- This is expected as the update is minor, not major

Please let me know if you need anything else. I believe this a very straight-forward and risk-free change.

lbstr commented 7 years ago

I'm having trouble understanding why 2 of the 5 travis builds failed. There was no compatible nodeunit version found, but I'm not sure why. Please let me know if there is anything I can do to help with this.

brandonb927 commented 7 years ago

@lbstr thanks for this, I'll take a look and see what we can do here. I think we might just merge as is, and even drop support for those older versions of node (I can't even get 0.6 to compile on my Macbook so I'm not too concerned). I know that previously we deferred upgrading restler because of a dependency issue (I believe a dependency in a newer version of restler doesn't support node 0.6/0.8 or something) but I may be mistaken.

Anyways, thanks for this!

lbstr commented 7 years ago

Thank you @brandonb927 - glad I could help!