search

sendwithus / sendwithus_nodejs

Sendwithus NodeJS Client
https://www.sendwithus.com
Apache License 2.0
22 stars 17 forks source link

Builds failing due to reference to github hosted "restler" package. #47

Closed kopertop closed 2 years ago

kopertop commented 3 years ago

Client version

4.3.1

Expected behaviour

Build should work

Actual behaviour

Build fails

Steps to reproduce

npm install sendwithus

This fails with the following error on a CodeBuild instance:


npm ERR! Error while executing:
--
275 | npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/sendwithus/restler.git
276 | npm ERR!
277 | npm ERR! Host key verification failed.
278 | npm ERR! fatal: Could not read from remote repository.
279 | npm ERR!
280 | npm ERR! Please make sure you have the correct access rights
281 | npm ERR! and the repository exists.
282 | npm ERR!
283 | npm ERR! exited with error code: 128
284 |  
285 | npm ERR! A complete log of this run can be found in:
286 | npm ERR!     /root/.npm/_logs/2021-03-05T20_07_59_815Z-debug.log

Even the build badge on the README file here says this build is failing, so I'm pretty sure there's an issue with the restler package referenced in this repository. I'm also not sure why this package would be referenced by a github URL rather than an npm proper package.

phil-ma commented 3 years ago

Hi @kopertop, thanks for reaching out!

I looked into the failing build issue and this was due to a failing test that occurred on a race condition. This seems to be separate from the issue you're experiencing.

The reason we have a GitHub URL referenced in the dependencies list is because we released a patched version of restler. This was due to a vulnerability concern with one of the dependencies within that package that has not been merged in yet. More information can be found here: https://github.com/sendwithus/sendwithus_nodejs/issues/44

I did some investigation into the error message you received and I believe it's due to an issue with npm v7. There's an open issue where npm uses ssh instead of https where referenced. It looks like it should still work with npm v6, but there might be a couple workarounds in that thread to help until that issue is resolved on v7.

brandond-dyspatch commented 2 years ago

Im going to be closing this issue due to lack of activity. If this issue is persists, please remake this issue in sendwithus/restler.

I do suggest updating your client version to our most recent release, and/or updating node and npm versions, if possible.