remove restler dependency and replace with node-fetch - Githubissues

sendwithus / sendwithus_nodejs

Sendwithus NodeJS Client

https://www.sendwithus.com

Apache License 2.0

22 stars 17 forks source link

remove restler dependency and replace with node-fetch #50

Closed rob-swu closed 3 years ago

rob-swu commented 3 years ago

Description

Motivation and Context

remove restler dependency and replace it with node-fetch should resolve https://github.com/sendwithus/sendwithus_nodejs/issues/49

How Has This Been Tested?

test suite

Types of changes

[x] Bug fix (non-breaking change which fixes an issue) - removes old dependency
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

matthewmayer commented 3 years ago

thanks! since you added a minimum requirement of Node 10.x shouldn't this be a semver-major change?

"engines": {
    "node": ">=10.0.0"
  }