sendyhalim / Yomu

📘 Manga reader app for Mac OS X
MIT License
194 stars 19 forks source link

Dark Mode #17

Open Tydox opened 5 years ago

Tydox commented 5 years ago

My eyes would appreciate, also very nice app! Can we save the manga locally? even if its just for a week, it will make it faster to load in my opinion, also instead of showing all the chapters in big headers, maybe put it in numbers and then we click on them and it prompts to open it. I can design a UI if you want. In addition to save last read point, would be nice!

sendyhalim commented 5 years ago

@Tydox hi there thanks for the suggestions! Regarding the dark mode I've been thinking about it too when reading a lot, I'm probably going to take a look at it this weekend to support macos dark mode theme and probably add a switch to turn it on/off manually 🍻 (not sure how hard it is, but it should be pretty straight forward though)

Can we save the manga locally? even if its just for a week, it will make it faster to load in my opinion

Yes it's very possible to enable local caching for this, it should be pretty easy.

also instead of showing all the chapters in big headers, maybe put it in numbers and then we click on them and it prompts to open it. I can design a UI if you want.

Hmm that would be nice, so it's some kind of pagination that spans across the current chapter neighbour? For example if there's 200 chapters and I'm on chapter 198 then it'd show 197 .. 198 .. 199? Also I'm curious about the prompt, I think it's fine without the prompt because you can always go back easily if you mis-click the link :D

In addition to save last read point, would be nice!

Now this is something that people been asking and I understand why people want it (in fact I've already implemented it in the iOS version haha), I think it's ambigious though, I mean what's the definition of "last read point"? Is it by just opening the chapter means it will be marked as last read point or is it when I reach the last chapter page?

Tydox commented 5 years ago

On\off manually, and I can assume that the manga is layered above the back panel which could overlay it, thus giving us dark mode (mojave color, and true black that will blend even better with the black managa), I think that mojave may have a built in feature that just needs to be enabled.

Local caching would be neat in case of wanting to load something for later when the internet would be off, or on the road.

Imagine "MANGA X" Chapter 1,2,3,4,5 (old>new\new>old), then you click the number, holding it can pop a small window saying what's its name, and clicking again opens it, or just a single click to open.

I would say keep it simple for right now, I think the best way to deal with no localized data is to just remember the last chapter read which can either be automatic or can be manually saved like you can do in ibooks where you click on save progress and it saves the last read page.

I can give more ideas but I prefer not to overload since it is not my app, and I still need to learn the lango XD

sendyhalim commented 5 years ago

Btw fyi @Tydox I'm planning to rewrite this mac app as soon as xcode 11 GM build out, I'll make sure that the dark mode feature included in the rewritten version 🍻