search

senecajs-labs / seneca-rabbitmq-transport

Seneca micro-services message transport over RabbitMQ messaging.
MIT License
15 stars 19 forks source link

Published version not usable? #19

Open nfantone opened 8 years ago

nfantone commented 8 years ago

Tagged version 0.2.1 has things like these in its code:

options = seneca.util.deepextend(
    {
      redis: {
        timeout:  so.timeout ? so.timeout-555 :  22222,
        type:     'redis',
        host:     'localhost',
        port:     6379,
      },
    },
    so.transport,
    options)
    }

Which seems to be the result of some well intentioned copy-pasting.

Is this plugin actually in a production-ready state? Should this be replaced by https://github.com/disintegrator/seneca-amqp-transport?

nfantone commented 8 years ago

After opening this issue, I stumbled upon this other issue: https://github.com/senecajs/seneca-rabbitmq-transport/issues/1

I'm still laughing. Not without remorse.