@nfantone any interest in updating the library to work with amqplib@latest and seneca@latest ?
I'm working on a bit of this, will likely fork the library into our internal monorepo to update dependencies... I'll also send a PR once it's in a working state. I've noticed the following so far:
promises from amqplib are no longer bluebird promises, so a few things need to be fixed up:
asCallback(done) need to change to .then(res => done(null, res), err => done(err))
thenReturn(someVar) needs to change to .then(() => someVar)
was getting an error about passing objects for queue and exchange when calling publish -- this this was a string before, but now it's an object, { queue, messageCount, consumerCount } -- I think it's just passing the result back from an amqp call?
Lots of tests needed to get fixed up to account for these, but I've got the tests passing at least.
@nfantone any interest in updating the library to work with amqplib@latest and seneca@latest ?
I'm working on a bit of this, will likely fork the library into our internal monorepo to update dependencies... I'll also send a PR once it's in a working state. I've noticed the following so far:
promises from amqplib are no longer bluebird promises, so a few things need to be fixed up:
asCallback(done)
need to change to.then(res => done(null, res), err => done(err))
thenReturn(someVar)
needs to change to.then(() => someVar)
was getting an error about passing objects for
queue
andexchange
when callingpublish
-- this this was a string before, but now it's an object,{ queue, messageCount, consumerCount }
-- I think it's just passing the result back from an amqp call?Lots of tests needed to get fixed up to account for these, but I've got the tests passing at least.