Use "local" seneca instances within actions

senecajs / seneca-auth

A Seneca user authentication plugin for Hapi and Express

http://senecajs.org

MIT License

33 stars 29 forks source link

Use "local" seneca instances within actions #51

Closed gkubisa closed 8 years ago

gkubisa commented 8 years ago

These changes allow the transaction ID (tx$) to be properly propagated between all actions involved in the processing of the client request.

AdrieanKhisbe commented 8 years ago

$ touch this

Why is this PR Pending? (should be rebase on new master, and maybe unmiletonoed)

mirceaalexandru commented 8 years ago

@AdrieanKhisbe @gkubisa

This PR conflicts should be fixed.

Now it seems that all changes are already implemented (or some where removed) by the PR:

https://github.com/senecajs/seneca-auth/pull/52

removed completely mail feature as this is not seneca-auth concern
use seneca-user actions instead of directly accessing the sys/* collections
removed pin() usage
local strategy was extracted as separate plugin.

@gkubisa Thank you for this PR and sorry it took so long to check it.

gkubisa commented 8 years ago

@mirceaalexandru I'm happy to just close this PR, as apparently the problem it was addressing has been already fixed (correct propagation of the tx$ value).