Merge 0.5.0 branch to main

senecajs / seneca-auth

A Seneca user authentication plugin for Hapi and Express

http://senecajs.org

MIT License

33 stars 29 forks source link

Closed mirceaalexandru closed 8 years ago

mihaidma commented 8 years ago

@AdrieanKhisbe: PR under review now.

AdrieanKhisbe commented 8 years ago

@mihaidma cool ! :) (Havve a look to https://github.com/senecajs/seneca-auth/pull/53, PR for 0.5.0 with coverage)

mihaidma commented 8 years ago

There are 4 tests out of 65 failing. Tested on Node 5.1.1, 4.1.0, 10.38, 12.9

AdrieanKhisbe commented 8 years ago

:tada: ! :)

@mirceaalexandru , do you want me to adapt #53 for coverage and standard seneca plugin header? :)

mirceaalexandru commented 8 years ago

@AdrieanKhisbe Yes please

AdrieanKhisbe commented 8 years ago

Just missing the publication on npm :)

mihaidma commented 8 years ago

No there are still dependencies on seneca-web and seneca-user that we have to solve. Hold on for 1-2 more days until we stabilize everything.

AdrieanKhisbe commented 8 years ago

okey dokey :)