search

senecajs / seneca-auth

A Seneca user authentication plugin for Hapi and Express
http://senecajs.org
MIT License
33 stars 29 forks source link

Use code as asserter #54

Closed AdrieanKhisbe closed 8 years ago

AdrieanKhisbe commented 8 years ago

Would anyone oppose a refactor to rely on code expects rather than assert in all the tests?

(I volounter for the change an dPR)

floridemai commented 8 years ago

@AdrieanKhisbe better leave this opened here for a while as this was part of a bigger refactor. I'll ping some people around to see about it. Not sure, but probably we should look into writing more tests. Does those cover everything? :)

AdrieanKhisbe commented 8 years ago

by "those", you mean current tests, or code

AdrieanKhisbe commented 8 years ago

for coverage, now we know with PR.

about cover, 84%: https://coveralls.io/github/AdrieanKhisbe/seneca-auth

mihaidma commented 8 years ago

@mirceaalexandru applied for maintainer. He has the 0.5.0 branch with a lot of fixes and tests. @AdrieanKhisbe @floridemai Please don't do any work on auth until all stuff is updated and merged (3 forks/branches to be merged). It might take 1-2 more days

AdrieanKhisbe commented 8 years ago

@mihaidma can I launch the operation now?

mihaidma commented 8 years ago

Officially we move to Code, feel free to launch the operation :)

AdrieanKhisbe commented 8 years ago

roger that