search

senecajs / seneca-entity

Entity plugin for seneca
MIT License
13 stars 15 forks source link

Possible leak detected #11

Closed shanel262 closed 8 years ago

shanel262 commented 8 years ago

Tests failing with Node@6 due to a possible leak with 'Reflect' #10 https://travis-ci.org/senecajs/seneca-entity/builds/129074838

m1ome commented 8 years ago

@shanel262 seneca currently not support Node 6 IMO.

m1ome commented 8 years ago

@shanel262 also you can look upon #9, it's kinda deprecated module

mihaidma commented 8 years ago

the Node 6 issue is caused by the Lab tests, see this: https://github.com/hapijs/lab/issues/581 Found a solution on how to solve this. Seneca and plugins are Node 6 compatible.

m1ome commented 8 years ago

@mihaidma yeah but this repo is kinda deprecated module.

mcdonnelldean commented 8 years ago

@m1ome Hey so this one shouldn't be marked as deprecated. I've closed that issue. @shanel262 @mihaidma My understanding is this is the correct repo for entitys. Can we confirm?

shanel262 commented 8 years ago

@mcdonnelldean Yeah this is the correct repo, I'm implementing a fix for Node 6 right now

mcdonnelldean commented 8 years ago

@shanel262 Awesome stuff. @m1ome we had a issue with Lab causing failures but we were given a work around by the Lab team. Seneca should be compatible with Node 6 (although I hear there are general Node 6 regressions appearing across the node ecosystem so there may be issues yet).