search

senecajs / seneca-entity

Entity plugin for seneca
MIT License
13 stars 15 forks source link

workaround to ensure mem-store is available early enough #24

Closed rjrodger closed 8 years ago

rjrodger commented 8 years ago

Using seneca.root avoids delay in loading mem-store.

New plugin system will need to handle loading dependent plugins.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 80.114% when pulling acdf564babf7ae3dab72b146487a581918847d10 on rjrodger:master into 884101204bbde86c710097a3b112f7961c615d2c on senecajs:master.

mcdonnelldean commented 8 years ago

@rjrodger The only issue with this, is you can no longer turn mem-store off, since it is loaded in the preload which doesn't have user options passed into entity available. If it ultimately doesn't matter for now (it gets overridden anyway) then this should be fine.

nfantone commented 8 years ago

@rjrodger and @mcdonnelldean I believe this PR broke the plugin completely. 1.2.0 always loads MemStore, there's no way to disable it and it ignores user options.

I'll be sending a new PR with a fix ASAP.

mihaidma commented 8 years ago

Seems like a serious issue. I'll check it tomorrow morning then verify the PR and republish.