Closed MHabashy10 closed 8 years ago
@Mohamed-Habshey This looks nice. Just a couple of linting issues. If you run npm run lint
it will tell you which ones.
@mcdonnelldean thanks i believe i had fixed the linting issues hope this helps
@Mohamed-Habshey Cheers, I'll get this reviewed in the next couple of days.
@mcdonnelldean Awesome :+1: looking forward for your review, Cheers.
@Mohamed-Habshey Could you remove the package.json bump and also add your details to the contributors list in package.json? I'll be merging this soon.
@mcdonnelldean done :+1: Thanks
@Mohamed-Habshey Super stuff. I've merged. Should be a release before the end of the week, just a couple more org wide changes to go.
That's Awesome :smile: @mcdonnelldean Thank you so much, Much appreciated :+1: Best Wishes
Hi
i submit this pr as i need to use redis as transport for my micro-services server deployed to heroku but to be able to use Heroku-redis addon which require us to use Redis Server Url Format so i modified the plugin accordingly and tested on heroku.
Use redis server Url and supply as param:
Provided how to use example in readme.
Dependencies update
Using quite() instead of the depreciated end()
to cleanly end client connection to the server.
Hope this Helps,
Regards M.Habashy