senecajs / seneca-redis-pubsub-transport

Seneca micro-services message transport over Redis pubsub
MIT License
16 stars 20 forks source link

Redis Server Url Support & Dependency Update #21

Closed MHabashy10 closed 8 years ago

MHabashy10 commented 8 years ago

Hi

i submit this pr as i need to use redis as transport for my micro-services server deployed to heroku but to be able to use Heroku-redis addon which require us to use Redis Server Url Format so i modified the plugin accordingly and tested on heroku.

Use redis server Url and supply as param:

Provided how to use example in readme.

require('seneca')({
 transport: {
    redis: {
      // you can use The URL of the Redis server. Format:-
      url: "[redis:]//[[user][:password@]][host][:port][/db-number][?db=dbnumber[&password=bar[&option=value]]]"
    }
  }
})

Dependencies update

"lodash": "^4.14.1",
"redis": "~2.6.2"

Using quite() instead of the depreciated end()

to cleanly end client connection to the server.

redis_in.quit()
redis_out.quit()

Hope this Helps,

Regards M.Habashy

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.09%) to 94.531% when pulling 4850f0057106d536006b0e6a8ad1a799863df8cb on Mohamed-Habshey:master into 402e96ffc6a1ba3ba9b8f6b034dbe3a9f038735d on rjrodger:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.09%) to 94.531% when pulling c44e57a3d1ecc3fec6abf13f6f36464145bc4aaf on Mohamed-Habshey:master into 402e96ffc6a1ba3ba9b8f6b034dbe3a9f038735d on rjrodger:master.

mcdonnelldean commented 8 years ago

@Mohamed-Habshey This looks nice. Just a couple of linting issues. If you run npm run lint it will tell you which ones.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.09%) to 94.531% when pulling 0eb74a00887a8840576e590d72b18947d254a350 on Mohamed-Habshey:master into 402e96ffc6a1ba3ba9b8f6b034dbe3a9f038735d on rjrodger:master.

MHabashy10 commented 8 years ago

@mcdonnelldean thanks i believe i had fixed the linting issues hope this helps

mcdonnelldean commented 8 years ago

@Mohamed-Habshey Cheers, I'll get this reviewed in the next couple of days.

MHabashy10 commented 8 years ago

@mcdonnelldean Awesome :+1: looking forward for your review, Cheers.

mcdonnelldean commented 8 years ago

@Mohamed-Habshey Could you remove the package.json bump and also add your details to the contributors list in package.json? I'll be merging this soon.

MHabashy10 commented 8 years ago

@mcdonnelldean done :+1: Thanks

mcdonnelldean commented 8 years ago

@Mohamed-Habshey Super stuff. I've merged. Should be a release before the end of the week, just a couple more org wide changes to go.

MHabashy10 commented 8 years ago

That's Awesome :smile: @mcdonnelldean Thank you so much, Much appreciated :+1: Best Wishes