Closed pthm closed 6 years ago
I noticed one more line where port and host are used: https://github.com/senecajs/seneca-redis-queue-transport/blob/master/redis-queue-transport.js#L108
The Travis failure seems to be caused by the decreasing test threshold. Is it possible to add more tests not to decrease the code coverage?
Fixed that issue with the host/port. Tried increasing test coverage but at a bit of a loose end as to how to test the Redis connection because its not exposed publicly. Exposing it would just require even more testing
@pthm Could you resolve the conflict? There were a couple of changes needed to be made that are now in. Don't sweat the coverage if you have hit a wall there. Just update the conflicts and I can merge in.
Updated the conflicts, not sure what happening with GitHub though. There also appears to be another issue with the happy-pin
test that exists in master too
i'll check this issue
it seems that the tests need reviewing/rewriting, this PR will take a while
Adds support for specifying a
url
property in options to use with.createClient()
As described here https://github.com/NodeRedis/node_redis#rediscreateclient