senecajs / seneca-redis-queue-transport

Seneca micro-services message transport with Redis queues
MIT License
9 stars 15 forks source link

Add support for redis connection url's #22

Closed pthm closed 6 years ago

pthm commented 8 years ago

Adds support for specifying a url property in options to use with .createClient()

As described here https://github.com/NodeRedis/node_redis#rediscreateclient

mihaidma commented 8 years ago

I noticed one more line where port and host are used: https://github.com/senecajs/seneca-redis-queue-transport/blob/master/redis-queue-transport.js#L108

The Travis failure seems to be caused by the decreasing test threshold. Is it possible to add more tests not to decrease the code coverage?

pthm commented 8 years ago

Fixed that issue with the host/port. Tried increasing test coverage but at a bit of a loose end as to how to test the Redis connection because its not exposed publicly. Exposing it would just require even more testing

mcdonnelldean commented 8 years ago

@pthm Could you resolve the conflict? There were a couple of changes needed to be made that are now in. Don't sweat the coverage if you have hit a wall there. Just update the conflicts and I can merge in.

pthm commented 8 years ago

Updated the conflicts, not sure what happening with GitHub though. There also appears to be another issue with the happy-pin test that exists in master too

mihaidma commented 8 years ago

i'll check this issue

mihaidma commented 8 years ago

it seems that the tests need reviewing/rewriting, this PR will take a while

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.8%) to 88.554% when pulling 6877024244d17e54e93ffe66540a9b3a3b9983bb on pthm:master into 5b98430292c6ea96caae7ed840ca9da22d60c5c3 on senecajs:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-12.4%) to 78.916% when pulling 9953e7542af5820d078c68bbd03acf0d37f4f232 on pthm:master into 5b98430292c6ea96caae7ed840ca9da22d60c5c3 on senecajs:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-12.4%) to 78.916% when pulling 5abbbf985954f8ec1eaf290e297fd44daa7f8900 on pthm:master into 5b98430292c6ea96caae7ed840ca9da22d60c5c3 on senecajs:master.