senecajs / seneca-transport

Seneca micro-services message transport over TCP and HTTP.
MIT License
63 stars 45 forks source link

web timeout vs http timeout #148

Open blueshirts opened 7 years ago

blueshirts commented 7 years ago

Similar to some of the examples in the README if you want to specify a top level timeout for http it seems like it must be labeled as web. The code below doesn't seem to do anything. If I change to transport name key from http to web it does seem to use the settings.

    var seneca = require('seneca')
    seneca({
        transport:{
          http:{
            timeout:500
          }
       }
    })

In the transport source I see the defaults listed under the web attribute also. Seems like http is an alias though does not work when it comes to settings. If I am correct this can be somewhat confusing. It would be nice if either http or web was used or the alias worked for all cases.

web: {
      type: 'web',
      port: 10101,
      host: '0.0.0.0',
      path: '/act',
      protocol: 'http',
      timeout: 5555,
      max_listen_attempts: 11,
      attempt_delay: 222,
      serverOptions: {}
},