senecajs / seneca-transport

Seneca micro-services message transport over TCP and HTTP.
MIT License
63 stars 45 forks source link

[Bug] Timeout of transport overrides all other global settings #160

Open wzrdtales opened 6 years ago

wzrdtales commented 6 years ago

This seems to be a bug, but not sure.

When you alter the timeout, whether through timeout$ or on the global timeout setting, it does not matter. As soon as those exceed the value of 5555 transport will override due to the following setting:

https://github.com/senecajs/seneca-transport/blob/55774150fa567a3e2448d590e4563ba5dfce7939/transport.js#L36

However this is quite problematic, as overriding this settings especially if you use the mesh module is not that simple. So how does this makes sense that the transport ignores global timeouts and carries around its own?