Refactor transport - Githubissues

geek commented 9 years ago

Added node v4 to travis
Changed reconnect-net dep to reconnect-core. reconnect-net was 2 years old and never published beyond 0.0.0
No changes to tests or util functions. The interface has stayed the same, just reorganized the transport code to make it easier to redo next.
Transport follows standard style + defensive measures from hapi: explicit internal/module functions, capitalized external module names
Pulled functions out of single function module.exports to make them easier to move around
Switched to camelCase for variables from snake_case
Brought in Hoek for default options support
Moved http and tcp into separate modules, making them possible to be pulled out as plugins

18% faster than published implementation

geek commented 9 years ago

@rjrodger there was enough of a difference between hoek.applyToDefaults and seneca.util.deepextend that I removed hoek

geek commented 9 years ago

@rjrodger this is good to go

mcdonnelldean commented 9 years ago

All in all LGTM, not sure if I'm a fan of snake_case but I'm not a fan of bikeshedding either :D

geek commented 9 years ago

@mcdonnelldean thanks for the review, I will fix the casing and move to lab next. Merging now!

mcdonnelldean commented 9 years ago

@geek Awesome!

senecajs / seneca-transport