search

senecajs / seneca-transport

Seneca micro-services message transport over TCP and HTTP.
MIT License
63 stars 45 forks source link

memory leak fix for tcp reconnect and typo fix for pushing tcp connections #54

Closed technicallyjosh closed 8 years ago

technicallyjosh commented 8 years ago

Found the memory leak issue by trying out seneca for the first time :)

My setup was as follows:

Seneca service listening on localhost:9090 API that had a client connected to localhost:9090

If the seneca service restarted about 8 times without the api restarting, you would get memory leak warnings from the event emitter on the API from the client.

This fix skips the initial setup of the socket connection if it's already been established.

mcdonnelldean commented 8 years ago

Nice work! LGTM

technicallyjosh commented 8 years ago

Thanks! I'm really digging Seneca!

mcdonnelldean commented 8 years ago

Awesome!