senecajs / seneca

A microservices toolkit for Node.js.
http://senecajs.org
MIT License
3.96k stars 314 forks source link

Can't use Pino logger with seneca-pino-logger adapter after seneca@3.14.0 #760

Open daniegarcia254 opened 5 years ago

daniegarcia254 commented 5 years ago

We can't start our app because Pino logger with senca-pino-logger adapter can't be use any longer after changes made in seneca@3.14.0.

I'v opened an issue in https://github.com/blueshirts/seneca-pino-adapter/issues/2 where you can see the error we're receiving, but still, you could maybe point the direction of the issue and propose a solution.

const Pino = require('pino');
const Noir = require('pino-noir');
const SenecaPinoLogger = require('seneca-pino-adapter');

const logger = new SenecaPinoLogger({
        logger: Pino({
            config: {
              serializers: Noir(require('./redactions.js'), undefined)
              , name: 'SenecaLogger'
              , level: 'info'
              , prettyPrint: { colorize: true }
            }
        })
    });

const seneca = require ('seneca') ({
    ....
    , internal: { logger: logger }
    , legacy: {
        logging: false
    }
})

We are using:

tswaters commented 4 years ago

I've got a PR that fixes this: https://github.com/blueshirts/seneca-pino-adapter/pull/3

Hopefully @blueshirts can merge that & publish a fixed version.