senecajs / seneca

A microservices toolkit for Node.js.
http://senecajs.org
MIT License
3.95k stars 314 forks source link

return this instead #815

Closed github-actions[bot] closed 4 years ago

github-actions[bot] commented 4 years ago

return this instead

https://github.com/senecajs/seneca/blob/3c7371a23bc25ae6bbbdcf4f52740a5981e2445c/lib/use.js#L405

            let resolved_options = {};
            /*
            try {
              resolved_options = delegate.util
                .Optioner(defaults, { allow_unknown: true })
                .check(outopts)
            } catch (e) {
              throw delegate.error('invalid_plugin_option', {
                name: fullname,
                err_msg: e.message,
                options: outopts,
              })
            }
            */
            let joi_schema = prepare_spec(delegate.util.Joi, defaults, { allow_unknown: true }, {});
            let joi_out = joi_schema.validate(outopts);
            //console.log('joi_out', joi_out)
            // TODO: return this instead
            if (joi_out.error) {
                throw delegate.error('invalid_plugin_option', {
                    name: fullname,
                    err_msg: joi_out.error.message,
                    options: outopts,
                });
            }
            else {
                resolved_options = joi_out.value;
            }
            //console.log('resolved_options', resolved_options)
            return {
                op: 'seneca_options',
                out: {
github-actions[bot] commented 4 years ago

Closed in 97e895ba4e5f92ddd87c5b14a006bbb862b3b10a

github-actions[bot] commented 4 years ago

Closed in 97e895ba4e5f92ddd87c5b14a006bbb862b3b10a