search

sengokudaikon / vscode-aider

Apache License 2.0
11 stars 0 forks source link

OpenAI API key is required even if not using OpenAI models #2

Open cori opened 2 weeks ago

cori commented 2 weeks ago

I'm using aider locally with a command along the lines of OPENROUTER_API_KEY=IAMGROOT aider --model openrouter/anthropic/claude-3.5-sonnet:beta and tho i get some seemingly-specious error messaging about that not being. asupported model (even tho i'm using the model name directly as suggested by aider in a previous session) once i ACK past the error messages I am in a successful aider session with OpenRouter's Claude Sonnet 3.5 without any other error messages.

When I do so using vscode-aider I'm presented by an "OpenAI API Key is required" message. Since aider doesn't actuallky need that as long as the api key for the selected model is properly set, can we remove that requirement? Not a big deal - I ended up just using IAMGROOT - i don't want to accidentally send requests to the wrong host - so it's a pretty easy workaround....

sengokudaikon commented 2 weeks ago

Hi. I'm half sure there's a warning in the settings that aider itself requires an openai key because of the voice config. Usually it's not a big deal to include just any key to even a credit-less account for compatibility purposes.

I'm unsure if removing the warning from the extension would be the right move, as this is an issue stemming from aider backend, and I don't want any unforeseen behaviour. So until #https://github.com/paul-gauthier changes the voice command configuration, I'd probably keep this as is?

cori commented 2 weeks ago

Totally your call, of course, and there is an easy workaround.

FWIW I'm not using voice mode.

And further to my original note, if I run aider in my terminal, with an explicitly-empty OPENAI_API_KEY but a populated OPENROUTER_API_KEY e.g.

OPENAI_API_KEY="" OPENROUTER_API_KEY=IAMGROOT aider --cache-prompts --yes-always --model openrouter/anthropic/claude-3.5-sonnet:beta --weak-model openrouter/anthropic/claude-3-haiku:beta

I do not receive any errors about a missing OPENAI_API_KEY.

So I'm slightly more (but not much more) than half-sure there isn't a warning in aider 0.61

cori@Pandoras-Vault sd-footage-manager % aider --version
aider 0.61.0

Again I have an easy workaround in-place so feel free to close! And thanks so much for adding the other LLM vendors!

sengokudaikon commented 2 weeks ago

Hm, I stand corrected then, apologies. You can try to contribute and submit a PR that resolves this, and I'll check it out, or otherwise I'll fix it when I have the time to update the extension later next week, as this is indeed an unnecessary behaviour of the extension.