search

sengsational / cwhelper

The code here is the background job for CW_EPG, an electronic program guide / DVR for Windows
1 stars 1 forks source link

The jar files in the project have duplicate entries. #44

Closed sengsational closed 4 days ago

sengsational commented 6 days ago

When building the runnable jar, either with the IDE process or the updated build, it's apparent that the jars in our build path overlap. Although this has not been causing problems, it could mean that different versions of those files could be running. This will take some analysis, but can probably be cleaned-up without too much trouble. The result is that the list of jars in the build path will be shorter and we'll know for sure which version of the library is running.

Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/commons-lang-2.6.jar had 6 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/commons-lang3-3.8.1.jar had 7 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/commons-logging-1.2.jar had 6 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/hsqldb-2.5.0.jar had 2 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/hsqldb.jar had 639 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/httpasyncclient-4.1.5.jar had 4 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/httpasyncclient-cache-4.1.5.jar had 10 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/httpclient-4.5.13.jar had 11 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/httpcore-4.4.15.jar had 10 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/httpcore-nio-4.4.15.jar had 12 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/jackcess-3.0.1.jar had 2 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/jna-5.7.0.jar had 2 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/jna-platform-5.7.0.jar had 6 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/mailapi.jar had 4 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/smtp.jar had 6 duplicate entries.
Jar C:\Users\Owner\github\cwhelper\CwHelperC\CwHelper_lib/ucanaccess-5.0.1.jar had 6 duplicate entries.
sengsational commented 4 days ago

97% of the duplication can be eliminated by removing one of the two hssqldb files.

Looking at the project Properties > Java Build Path > Order and Export, I see that hssqldb-2.5.0.jar is ahead of hssqldb.jar, so the latter is not being referenced since all classes are listed in both files, so I removed it from the project.

Checked in the altered .classpath configuration file and removed the jar file: https://github.com/sengsational/cwhelper/commit/85da9acd8f39cce8e1950f913daf054a8f505c83

The remaining duplication is caused by each jar file having the same name for license text files and notices text files. These don't make a difference in the operation of our application, so they can be safely ignored.