search

sengsational / cwhelper

The code here is the background job for CW_EPG, an electronic program guide / DVR for Windows
1 stars 1 forks source link

Updates to fix getCapturesForRecurring #5

Closed TPeterson94070 closed 11 months ago

sengsational commented 11 months ago

If you're running the latest from my repository, you should be able include in this PR "aCapture.setRecurrenceDays(recurring);" right under where you added "aCapture.setRecurring(true);".

TPeterson94070 commented 11 months ago

Ok, I mistook your original comment as simply a stylistic note rather than a request for my action. I'll edit or resubmit the PR.

-------- Original Message -------- From: Dale @.> Sent: December 23, 2023 7:41:16 AM PST To: sengsational/cwhelper @.> Cc: TPeterson94070 @.>, Author @.> Subject: Re: [sengsational/cwhelper] Updates to fix getCapturesForRecurring (PR #5)

@sengsational commented on this pull request.

@@ -1467,6 +1467,7 @@ public ArrayList getCapturesForRecurring(String channelName, Slot origi Capture aCapture = getCaptureForChannelNameSlotAndTuner(channelName, listedSlot, tunerString, protocol); if (aCapture != null){ captureList.add(aCapture);

  • aCapture.isRecurring = true;

My expertise with managing changes through this PR mechanism is limited. My advice would be to add to or somehow edit the PR to get everything in it. The "right way" might be to edit the existing PR or to make a new one. I really don't know. I like that we're figuring this stuff out, though.

-- Reply to this email directly or view it on GitHub: https://github.com/sengsational/cwhelper/pull/5#discussion_r1435634732 You are receiving this because you authored the thread.

Message ID: @.***>

TPeterson94070 commented 11 months ago

It appears that my edited repository is already now part of this PR...so I'm done???

sengsational commented 11 months ago

I created a feature branch. Although my email said I wasn't going to do that right now, it was quick on my side. If you can figure out how to do a PR against the feature branch with all of your commits, I can merge those into the feature branch, and we can both work on the broken code while leaving the master branch (working code) alone.