senhorsolar / concavehull

Finds the concave hull around a set of points by leveraging the Delaunay triangulation
MIT License
32 stars 10 forks source link

Infinite loop some point sets #2

Closed Quietliz closed 1 month ago

Quietliz commented 2 months ago

if (hbl == INVALID_INDEX) { std::size_t e = hull_start; do { if (hull_tri[e] == bl) { hull_tri[e] = a; break; } e = hull_next[e]; } while (e != hull_start); } @senhorsolar What is the reason for the infinite loop that occurs for some point sets and how to modify it, thanks!

senhorsolar commented 1 month ago

Hey @Quietliz, it's been a while since I looked at this but I plan on updating it soon. The delaunay triangulation was someone else's code and it looks like there's a more up-to-date version of it.

senhorsolar commented 1 month ago

Fixed by using updated delaunator implementation