search

senior-knights / course-schedulizer

📝 Create semester schedules without stress
https://senior-knights.github.io/course-schedulizer/
MIT License
10 stars 4 forks source link

Half semester conflict #278

Closed rpruim closed 1 year ago

rpruim commented 1 year ago

I improved the test for term overlaps and added low-level tests to confirm that it is working as intended.

rpruim commented 1 year ago

@kvlinden, @charkour -- either one of you want to review this? It would be nice to get this into production if it isn't causing any problems.

charkour commented 1 year ago

I can take a look.

Would you be willing to email me a schedule I can test with, @rpruim?

rpruim commented 1 year ago

I emailed some example files. There is also a link in #250 to an example from CS.

rpruim commented 1 year ago

I think there are some older examples in the repo as well (perhaps used for some of the tests?). I haven't dug into that too deeply yet, but we should probably create some new import/export tests since we have chanced the import/export process.

rpruim commented 1 year ago

I just deployed this.

rpruim commented 1 year ago

@charkour, thanks for approving.

@kvlinden, you could load your CS schedule and see if there are any remaining non-conflicts being flagged as conflicts. I didn't immediately spot any, but you can probably go through the list more quickly than I can since I need to open up the sections to see when they are scheduled and you might just remember.

kvlinden commented 1 year ago

The current production branch appears to be working properly. Thanks!