search

senior-knights / course-schedulizer

📝 Create semester schedules without stress
https://senior-knights.github.io/course-schedulizer/
MIT License
10 stars 4 forks source link

get app running locally #332

Open charkour opened 1 year ago

charkour commented 1 year ago

Hi @kvlinden and @rpruim. I have some free time this summer, so I'd like to modernize and improve the third-party dependencies for this project so you and the students can more easily add features in the future. If you'd like to talk in more detail, please email me. Thank you

First order of business is to actually run the app locally with modern a modern JS runtime (Node v18) This fixes bugs to allow the app to run locally with Node v18 and PNPM v8. This updates FullCalendar to v6 to fix some vdom issues.

To update to Node v18, use Node Version Manager To use pnpm, follow their docs

Many of the updates were due to ESLint rule changes and auto-formatting.

charkour commented 1 year ago

Tests faill because of switching to PNPM

kvlinden commented 1 year ago

Thanks for this, Charles. Alas, we've been buried with summer projects and the new MDS program going live next month. We will be fielding a Schedulizer student team in early September, so hopefully we'll have some time to resurrect this system and review your proposed changes.

charkour commented 1 year ago

Roger that. I can verify my changes work and merge them in. That way there's no hassle for the students this fall.

kvlinden commented 1 year ago

@charkour - I'm finally coming back around to this issue and am having trouble getting the system running locally. I haven't done active development on this system for a while, so I'm probably forgetting some key steps.

I verified that I've got Node 18.17.1; NPM 10.0.0; PNPM 8.6.0 on WSL2 Linux, and then I tried running the system on both the production and then the fix-local branches.

(naive?) question: is npm-install and then npm-start the right way to start the local server?

charkour commented 1 year ago

npm install worked on production but npm start failed to bring up the system (citing errors in &fullcalendar)

Yup! I ran into that too. This branch aims to fix those issues.

npm install failed on fix-local (citing errors with eslint).

The ESLint errors should be fixable, so you'll need to do that quickly. The console will display what needs to be updated.

The correct way to run this is running the commands pnpm install then pnpm start in the product directory with the package.json file.

charkour commented 1 year ago

Please feel free to push to this branch. I cannot confidently commit time to dev work, but I'll advise as possible.

kvlinden commented 1 year ago

Thanks - I'm not familiar with pnpm. It's running now, but generating an error about installing @testing-library/react. I can work on that.