search

seniv / react-native-notifier

Fast and simple in-app notifications for React Native
MIT License
1.05k stars 60 forks source link

Feature request: custom font style for title and description #13

Closed MoKhajavi75 closed 4 years ago

MoKhajavi75 commented 4 years ago

Hey

Thanks for your great lib! It's awesome :heart: I just want to change the title and description style. I know there is a way to render CustomComponent but I guess it's overworking!

I created a PR and hope you don't prefer the CustomComponent way :grin:

seniv commented 4 years ago

Hey @MohamadKh75, thanks for the PR! This makes sense. I didn't add the ability to customize Components from the beginning only because I thought that most people will not use the default components and create their own components 😄

I'll also add the ability to pass Image styles of the Notification component.

MoKhajavi75 commented 4 years ago

Great! And when do we have a release :grin: ?

seniv commented 4 years ago

In a couple of minutes, I'm finishing the imageStyle param)

BTW, I updated the docs from your PR for a little bit here: https://github.com/seniv/react-native-notifier/commit/a3e92b806ae621f7ac3c4a2bb975987eaed0c881 Because title/descriptionStyle will work only as componentProps

seniv commented 4 years ago

Done, 1.3.0 is released🙂

MoKhajavi75 commented 4 years ago

Tnx :rocket: